Allow sync subs to allow m.Respond with auto-unsub #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <[email protected]>
kozlovic
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
LGTM but I really wonder why you did not consider simply adding the connection as a private field to the Msg structure (which would be immutably set when creating the message in processMsg). This is adding 8 bytes to a structure, but that should not be a problem unless users store lots of them in mem.
|
I try to be aware of creating allocations in things with greater N probabilities. msgs > subs > connections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #486
Signed-off-by: Derek Collison [email protected]