[ADDED] Allow client to choose whether to execute callbacks on Close() #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disables the invocation of callbacks if the client code directly calls Close(). If case of a library initiated close, callbacks will be invoked as they currently are.
kozlovic
requested changes
Aug 30, 2019
kozlovic
requested changes
Sep 3, 2019
aricart
force-pushed
the
close-notifications
branch
from
b122fd2
to
ca056be
Compare
aricart
force-pushed
the
close-notifications
branch
from
ca056be
to
d2b2945
Compare
kozlovic
changed the title
kozlovic
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added connection option
NoCallbacksAfterClientClosewhich disables the invocation of callbacks if the client code directly callsClose(). In case of a library initiated close, callbacks will beinvoked as they currently are.