Support connecting to hostnames that resolve to IPv6 addresses (#406)

nats-io · Sep 24, 2020 · 772cbc8 · 772cbc8
1 parent 50cb20d
commit 772cbc8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 54 deletions.
diff --git a/src/NATS.Client/Conn.cs b/src/NATS.Client/Conn.cs
@@ -25,7 +25,6 @@
 using System.Security.Authentication;
 using System.Globalization;
 using System.Diagnostics;
-using NATS.Client.Extensions;
 using NATS.Client.Internals;
 
 namespace NATS.Client
@@ -378,7 +377,8 @@ internal void open(Srv s, int timeoutMillis)
                         sslStream = null;
                     }
 
-                    client = createTcpClient(s.url);
+                    client = new TcpClient(AddressFamily.InterNetworkV6);
+                    client.Client.DualMode = true;
                     var task = client.ConnectAsync(s.url.Host, s.url.Port);
                     // avoid raising TaskScheduler.UnobservedTaskException if the timeout occurs first
                     task.ContinueWith(t => GC.KeepAlive(t.Exception), TaskContinuationOptions.OnlyOnFaulted);
@@ -401,15 +401,6 @@ internal void open(Srv s, int timeoutMillis)
                 }
             }
 
-            private static TcpClient createTcpClient(Uri uri)
-            {
-                var interNetworkAddressFamily = uri.GetInterNetworkAddressFamily();
-
-                return interNetworkAddressFamily != null
-                       ? new TcpClient(interNetworkAddressFamily.Value)
-                       : new TcpClient();
-            }
-
             private static bool remoteCertificateValidation(
                   object sender,
                   X509Certificate certificate,

diff --git a/src/NATS.Client/Extensions/UriExtensions.cs b/src/NATS.Client/Extensions/UriExtensions.cs
diff --git a/src/Tests/UnitTests/Extensions/TestUriExtensions.cs b/src/Tests/UnitTests/Extensions/TestUriExtensions.cs