Fix memory leak on timed out connection attempt #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colin Sullivan <[email protected]>
|
We may not dispose of |
|
Good catch, thanks @watfordgnf. I'll add that to this PR. |
Signed-off-by: Colin Sullivan <[email protected]>
Signed-off-by: Colin Sullivan <[email protected]>
|
@watfordgnf, added one more small thing - nulled out the ssl stream after dispose for good measure. I think this should do it. Tests are green locally, will let you know when they're green for CI. |
|
CI Is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a memory leak upon a failed connection.
Note, upon a first failed connection there will be a bump in memory of a few Kb as the .NET runtime allocates objects required to create a socket. This is a one time allocation. With this fix, memory remains stable after that point.
In debugging this, some tasks associated with the TCP client connection were collected while others were not, so there was not a one-to-one leaked object per failed attempt. No leaked objects had references to, or were referenced by NATS.Client objects - at least that the memory profiler would report. I did not get to the bottom of that mystery, but quantitatively testing a loop of 1000 failed connection attempts measuring memory + object counts indicated this bug was fixed with the changes.
Resolves #236.
Signed-off-by: Colin Sullivan [email protected]