Custom inbox prefix #322
Merged
Custom inbox prefix #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After discussion I reverted from functional generators to simple string prefix. Not sure if you think there should be validation when assigning the value? Are there any specific rules that should be enforced then? Will complement with test. |
|
Good point on validation.... You can validate with |
|
@ColinSullivan1 Validation added. Still lacks one or two integration tests. |
Issues - Validation is not the same as subject - Options did not copy value in constructor
|
@ColinSullivan1 @watfordgnf I changed the validation as I do believe it can not be exactly as subjects. Might be wrong. Also added integration test which also found an issue. I've nothing else planned for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for custom inbox prefix to solve #237