Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #343

Merged
merged 4 commits into from
Nov 26, 2019
Merged

Improvements #343

merged 4 commits into from
Nov 26, 2019

Conversation

danielwertheim
Copy link
Collaborator

  • Improves flusher and read thread management:
    • On failure, try "clean" next thread
    • On success, remove from list of threads
  • Fixes potential non cleaning of stream in Parser
  • Fixes non disposal of Parser

@danielwertheim danielwertheim self-assigned this Nov 25, 2019
watfordgnf
watfordgnf approved these changes Nov 25, 2019
View reviewed changes
Copy link
Collaborator

@watfordgnf watfordgnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/NATS.Client/Conn.cs Show resolved Hide resolved
ColinSullivan1
ColinSullivan1 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you want to add the clear go ahead. Either way works for me.

@danielwertheim danielwertheim merged commit d9a97e1 into nats-io:master Nov 26, 2019
@danielwertheim danielwertheim deleted the improvements branch November 26, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watfordgnf watfordgnf watfordgnf approved these changes

@ColinSullivan1 ColinSullivan1 ColinSullivan1 approved these changes

Assignees

@danielwertheim danielwertheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielwertheim @ColinSullivan1 @watfordgnf