Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 286, manually updated #346

Merged
merged 6 commits into from
Nov 27, 2019
Merged

PR 286, manually updated #346

merged 6 commits into from
Nov 27, 2019

Conversation

danielwertheim
Copy link
Collaborator

This is a manual integration of master into changes initially done in #286 (by @CycoPH) so that we can close that PR and get the changes in.

Copy link
Collaborator

@watfordgnf watfordgnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CycoPH
Copy link

CycoPH commented Nov 28, 2019

Thank you for accepting the PR

@danielwertheim danielwertheim deleted the pr-286-updated branch November 28, 2019 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants