Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes so that conn.unsubscribe does not return null #347

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Fixes so that conn.unsubscribe does not return null #347

merged 1 commit into from
Nov 27, 2019

Conversation

danielwertheim
Copy link
Collaborator

Extracts CompletedTask and uses a completed task instead of null.

Extracts CompletedTask and uses a completed task instead of null.
@@ -0,0 +1,30 @@
// Copyright 2015-2018 The NATS Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick... 2019

Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ColinSullivan1 ColinSullivan1 merged commit 0d73ef1 into nats-io:master Nov 27, 2019
@danielwertheim danielwertheim deleted the fixes-potentiall-nullref branch November 28, 2019 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants