Mostly tests work #348
Merged
Mostly tests work #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some cleaning as well
Currently only for NATSNoServersException
|
Will replace with normal fact and try the built-in Azure DevOps features for rerunning tests. |
Changes to VSTest and enables re-run of integration tests.
|
@ColinSullivan1 @watfordgnf reverted the custom fact and instead changed CI & CD to use VSTest task for executing tasks and configured integration tests to allow re-run of failing tests. Nothing more planned in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly test improvements and cleaning:
Using new customNatsFactin integration tests which currently retries (1 time) uponNATSNoServersException. Obviously trying to stabilize the tests would be better.Sample of NatsFact outcome
Custom fact has been removed from PR.
Test failed (reported as skipped) then fails in retry:Test failed (reported as skipped) then succeeds in retry: