Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly created threads now set IsBackground=true to avoid prevent… #354

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Explicitly created threads now set IsBackground=true to avoid prevent… #354

merged 1 commit into from
Jan 13, 2020
+5 −0

Conversation

SkinnySackboy
Copy link
Contributor

…ing a process using this library from terminating.

@SkinnySackboy
Explicitly created threads now set IsBackground=true to avoid prevent…
450eef9 
…ing a process using this library from terminating.
@SkinnySackboy SkinnySackboy mentioned this pull request Jan 13, 2020
Closed
watfordgnf
watfordgnf approved these changes Jan 13, 2020
View reviewed changes
Copy link
Collaborator

@watfordgnf watfordgnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI.

@ColinSullivan1
Copy link
Member

Looks like something is up with CI...

ColinSullivan1
ColinSullivan1 approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ColinSullivan1 ColinSullivan1 merged commit b4c7ca3 into nats-io:master Jan 13, 2020
@watfordgnf watfordgnf mentioned this pull request Jan 23, 2020
Closed
@watfordgnf
Copy link
Collaborator

Resolves #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinSullivan1 ColinSullivan1 ColinSullivan1 approved these changes

@watfordgnf watfordgnf watfordgnf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SkinnySackboy @ColinSullivan1 @watfordgnf