Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More optimizations for InFlightRequest #362

Merged
merged 12 commits into from
Jan 30, 2020
Merged

More optimizations for InFlightRequest #362

merged 12 commits into from
Jan 30, 2020

Commits on Jan 28, 2020

  1. Make internals visible to UnitTests

    @jasper-d
    jasper-d committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    113d781 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for InFlightRequest 

    - Move InFlightRequest to its own file
- Make InFlightRequest internal
    @jasper-d
    jasper-d committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    c02975a View commit details
    Browse the repository at this point in the history

  3. Check for null in constructor of InFlightRequest 

    - Remove unnecessary null checks in Dispose
    @jasper-d
    jasper-d committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    3db6979 View commit details
    Browse the repository at this point in the history

  4. Move TCS initialization out of ctor

    @jasper-d
    jasper-d committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    9bdbcaa View commit details
    Browse the repository at this point in the history

  5. Create CTS only if necessary

    @jasper-d
    jasper-d committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    9be02f0 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. Avoid closing over TCS

    @jasper-d
    jasper-d committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    2a3b06d View commit details
    Browse the repository at this point in the history

  2. Throw TCE instead of NATSTimeoutException

    @jasper-d
    jasper-d committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    a02ee1e View commit details
    Browse the repository at this point in the history

  3. Add license headers

    @jasper-d
    jasper-d committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    ea2d2c4 View commit details
    Browse the repository at this point in the history

  4. Add InFlightRequest benchmarks

    @jasper-d
    jasper-d committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    086f103 View commit details
    Browse the repository at this point in the history

  5. Adjust test name to reflect changed behaviour

    @jasper-d
    jasper-d committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    5e35daf View commit details
    Browse the repository at this point in the history

  6. Don't close over timeout either & add docs 

    - Enforce avoidance of closure by using a static method
    @jasper-d
    jasper-d committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    3c7517e View commit details
    Browse the repository at this point in the history

  7. Don't pack MicroBenchmarks

    @jasper-d
    jasper-d committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    e225b97 View commit details
    Browse the repository at this point in the history