Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make exceptions constructors public to enable mocking #366

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Make exceptions constructors public to enable mocking #366

merged 1 commit into from
Feb 26, 2020

Conversation

kaspertygesen
Copy link

I would like to be able to mock exceptions thrown by NATS.

NSubstitute example:

nats.Request(payload).ThrowsForAnyArgs(new NATSTimeoutException());

It would be great to be able to easily test for different NATS exceptions using mocks like this.

ColinSullivan1
ColinSullivan1 approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the contribution!

@ColinSullivan1 ColinSullivan1 merged commit 0ed68c3 into nats-io:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinSullivan1 ColinSullivan1 ColinSullivan1 approved these changes

@danielwertheim danielwertheim Awaiting requested review from danielwertheim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaspertygesen @ColinSullivan1