Fix sync/async deadlock #404
Conversation
|
I don't think its a dependency we can take, but Microsoft's vs-threading repo has nice handlers for sync-over-async (aka JoinableTaskFactory) that perhaps would be a solution in this space. |
|
I don't know vs-threading, but looks like it wouldn't work for us indeed: https://github.com/microsoft/vs-threading/blob/master/src/Microsoft.VisualStudio.Threading/Microsoft.VisualStudio.Threading.csproj#L3, more specifically https://github.com/microsoft/vs-threading/search?q=RunContinuationsAsynchronously&unscoped_q=RunContinuationsAsynchronously (that's used by the JoinableTaskFactory). |
jasper-d
force-pushed
the
jasper-d/continue-async
branch
from
199b334
to
4306d1d
Compare
(cherry picked from commit 18730fa)
jasper-d
force-pushed
the
jasper-d/continue-async
branch
from
06b150a
to
ec0a317
Compare
|
Thanks! |
| throw; | ||
| } | ||
|
|
||
| return request.Waiter.Task.GetAwaiter().GetResult(); |
There was a problem hiding this comment.
Does this still timeout after timeout milliseconds?
There was a problem hiding this comment.
Yes, timeout is passed through setupRequest to InflightRequest where it's used to set the timeout.https://github.com/nats-io/nats.net/blob/ec0a317bde5cf0b7d88a5e63c83ae43527d0274c/src/NATS.Client/Internals/InFlightRequest.cs#L72
Fixes a deadlock #395 using TaskCreationOptions.RunContinuationsAsynchronously on netstandard1.6.
No integration test because I couldn't make it fail reliably (before the fix).
Upgraded to net46 since #394 will do it anyways and it avoids an ugly workaround.