Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISubscription should inherit IDisposable #438

Merged
merged 1 commit into from
Feb 25, 2021
Merged

ISubscription should inherit IDisposable #438

merged 1 commit into from
Feb 25, 2021

Conversation

ColinSullivan1
Copy link
Member

Resolves #433

Signed-off-by: Colin Sullivan [email protected]

watfordgnf
watfordgnf approved these changes Feb 25, 2021
View reviewed changes
Copy link
Collaborator

@watfordgnf watfordgnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we'll probably want a note for folks who mock our subscriptions in testing that they may see this as a breaking change.

@ColinSullivan1 ColinSullivan1 merged commit e7581ac into master Feb 25, 2021
@ColinSullivan1 ColinSullivan1 deleted the sub-dispose branch February 25, 2021 21:48
@ColinSullivan1
Copy link
Member Author

Thanks @watfordgnf for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watfordgnf watfordgnf watfordgnf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ISubscription should inherit IDisposable
2 participants
@ColinSullivan1 @watfordgnf