Readme notes for Subject Validation change in 1.1.0 #846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note regarding Subject Validation
With the upgrade to 1.1.1, applications may start throwing exceptions when subscribing to streams:
Let's say you have a stream subject
foo.>
And you are subscribing tofoo.a
.When you don't supply a filter subject on a consumer, it becomes
>
, which means all subjects.So this is a problem, because you think you are subscribing to
foo.a
but in reality, without this check,you will be getting all messages subjects you do not want.
Validating the subscribe subject against the filter subject is needed to prevent this.
Unfortunately, this makes existing code throw the
90011
exception.