Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme notes for Subject Validation change in 1.1.0 #846

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Nov 24, 2023

Note regarding Subject Validation

With the upgrade to 1.1.1, applications may start throwing exceptions when subscribing to streams:

90011 Subject does not match consumer configuration filter

Let's say you have a stream subject foo.> And you are subscribing to foo.a.
When you don't supply a filter subject on a consumer, it becomes >, which means all subjects.

So this is a problem, because you think you are subscribing to foo.a but in reality, without this check,
you will be getting all messages subjects you do not want.
Validating the subscribe subject against the filter subject is needed to prevent this.
Unfortunately, this makes existing code throw the 90011 exception.

Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit bf0c0e2 into main Nov 27, 2023
1 check passed
@scottf scottf deleted the subject-validation-readme branch November 27, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants