Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KV Atomic Delete and Purge #872

Merged
merged 1 commit into from
Mar 6, 2024
Merged

KV Atomic Delete and Purge #872

merged 1 commit into from
Mar 6, 2024

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Mar 5, 2024

nats-io/nats-architecture-and-design#271
nats-io/nats.java#1091

What's in this patch?

  1. New public methods in IKeyValue for delete and purge with optimistic concurrency support:
void Delete(String key, ulong expectedRevision);
void Purge(String key, ulong expectedRevision);
  1. New unit test TestAtomicDeletePurge with positive and negative cases.

@scottf scottf requested a review from mtmk March 5, 2024 22:55
@scottf scottf mentioned this pull request Mar 5, 2024
Open
15 tasks
mtmk
mtmk approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit f7a537a into main Mar 6, 2024
1 check passed
@scottf scottf mentioned this pull request May 29, 2024
Closed
@scottf scottf deleted the atomic-kv-delete branch July 8, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf @mtmk