Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Store use over leaf-hub domain #900

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Object Store use over leaf-hub domain #900

merged 2 commits into from
Jun 17, 2024

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Jun 17, 2024

No description provided.

@@ -32,9 +33,9 @@
namespace IntegrationTests
{
[SuppressMessage("ReSharper", "ParameterOnlyUsedForPreconditionCheck.Local")]
public class TestObjectStore : TestSuite<OneServerSuiteContext>
public class TestObjectStore : TestSuite<ObjectStoreSuiteContext>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to a context that has support to run a hub and leaf

@scottf scottf requested a review from mtmk June 17, 2024 19:38
@@ -204,7 +204,7 @@ public ObjectInfo Get(string objectName, Stream outputStream)
}
else {
IJetStreamPushSyncSubscription sub = js.PushSubscribeSync(
PubSubChunkSubject(oi.Nuid),
RawChunkSubject(oi.Nuid),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix/bug

@@ -226,29 +226,35 @@ public void RunInJsServer(TestServerInfo testServerInfo, string config, Action<I
}
}

public const string HubDomain = "HUB";
public const string LeafDomain = "LEAF";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made const so can be known to tests

streamWriter.WriteLine("jetstream {");
streamWriter.WriteLine(" domain: HUB");
streamWriter.WriteLine(" store_dir: " + TestBase.TempConfDir());
streamWriter.WriteLine(" domain: " + HubDomain);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the constant and specify a unique store dir for each server

streamWriter.WriteLine("jetstream {");
streamWriter.WriteLine(" domain: LEAF");
streamWriter.WriteLine(" store_dir: " + TestBase.TempConfDir());
streamWriter.WriteLine(" domain: " + LeafDomain);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the constant and specify a unique store dir for each server


public class KeyValueSuiteContext : SuiteContext
public class HubLeafSuiteContext : SuiteContext
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactored for reuse since object store needs the same stuff

Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 8be62fc into main Jun 17, 2024
1 check passed
@scottf scottf deleted the object-store-domain branch June 17, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants