-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object Store use over leaf-hub domain #900
Conversation
@@ -32,9 +33,9 @@ | |||
namespace IntegrationTests | |||
{ | |||
[SuppressMessage("ReSharper", "ParameterOnlyUsedForPreconditionCheck.Local")] | |||
public class TestObjectStore : TestSuite<OneServerSuiteContext> | |||
public class TestObjectStore : TestSuite<ObjectStoreSuiteContext> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to a context that has support to run a hub and leaf
@@ -204,7 +204,7 @@ public ObjectInfo Get(string objectName, Stream outputStream) | |||
} | |||
else { | |||
IJetStreamPushSyncSubscription sub = js.PushSubscribeSync( | |||
PubSubChunkSubject(oi.Nuid), | |||
RawChunkSubject(oi.Nuid), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix/bug
@@ -226,29 +226,35 @@ public void RunInJsServer(TestServerInfo testServerInfo, string config, Action<I | |||
} | |||
} | |||
|
|||
public const string HubDomain = "HUB"; | |||
public const string LeafDomain = "LEAF"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made const so can be known to tests
streamWriter.WriteLine("jetstream {"); | ||
streamWriter.WriteLine(" domain: HUB"); | ||
streamWriter.WriteLine(" store_dir: " + TestBase.TempConfDir()); | ||
streamWriter.WriteLine(" domain: " + HubDomain); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the constant and specify a unique store dir for each server
streamWriter.WriteLine("jetstream {"); | ||
streamWriter.WriteLine(" domain: LEAF"); | ||
streamWriter.WriteLine(" store_dir: " + TestBase.TempConfDir()); | ||
streamWriter.WriteLine(" domain: " + LeafDomain); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the constant and specify a unique store dir for each server
|
||
public class KeyValueSuiteContext : SuiteContext | ||
public class HubLeafSuiteContext : SuiteContext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored for reuse since object store needs the same stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.