ObjStore empty list fix #572
Conversation
| await _commandTask; | ||
|
|
||
| _msgChannel.Writer.TryComplete(); | ||
|
|
There was a problem hiding this comment.
why did we change these? did you encounter an issue? (you're probably right to make these changes, I just can't remember my reasoning here so just curious)
There was a problem hiding this comment.
Yes, I encountered some problem.
Before exiting WatchAsync, if Enumerable is empty, call pushConsumer.Init();
The consumer is initialized and the same consumer is immediately deleted in the dispose method.
The creation operation _consumerCreateTask has not yet had time to complete and it requires an active _commandChannel, but it is already closed. Based on this, I decided to change the order of stopping channel reading.
There was a problem hiding this comment.
Otherwise, when Dispose we get NatsJSApiException: consumer not found.
There was a problem hiding this comment.
awesome, thanks fixing that 💯 should we stick this as comment on top of the relevant lines do you think?
There was a problem hiding this comment.
Good idea! Added.
There was a problem hiding this comment.
LGTM thanks @Ivandemidov00
ps @Ivandemidov00 are you on slack.nats.io dotnet channel?
|
ouch sorry @Ivandemidov00 I keep forgetting this finally we put a check in github. could you please sign your commits? cheers edit it's a CNCF requirement apparently. thanks again! |
|
I signed the commits and moved them to the next branch #578. |
Resolves #563