Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-unsubscribe implementations and fixes #70

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Jun 30, 2023

  • Auto-unsubscribe on max-msgs, timeout and idle timeout
  • Pass NatsMsg by ref to reduce copy overhead
  • Hidden internal INatsSub API from public API using explicit interface implementations

* Auto-unsubscribe on max-msgs, timeout and idle timeout
* Pass NatsMsg by ref to reduce copy overhead
* Hidden internal INatsSub API from public API using explicit
  interface implementations
This was linked to issues Jun 30, 2023
@mtmk mtmk marked this pull request as ready for review June 30, 2023 11:07
@mtmk mtmk requested a review from caleblloyd June 30, 2023 11:07
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 953692e into main Jun 30, 2023
2 checks passed
@mtmk mtmk deleted the 67-auto-unsubscribe-options branch June 30, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NatsSub information hiding Auto-unsubscribe options
2 participants