[FIX] this simply makes a curve key conform to the KeyPair interface by rejecting uses that are not applicable #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aricart
requested review from
derekcollison and
philpennock
and removed request for
derekcollison
Pull Request Test Coverage Report for Build 165
💛 - Coveralls |
Pull Request Test Coverage Report for Build 184
💛 - Coveralls |
aricart
force-pushed
the
normalize-curve
branch
from
cb9eedb
to
f0539fd
Compare
aricart
force-pushed
the
normalize-curve
branch
from
3c2fd92
to
1120a48
Compare
|
Maybe open up new PR on top pf fresh main.. Should have rebased this one vs merge. |
Signed-off-by: ainsley <[email protected]>
Since the JWT is read from a file that may be produced programmatically (in one form or another), it is possible for there to be one or more additional whitespace surrounding the JWT in the decorated file. This simply ensure the whitespace is trimmed as is performed when parsing the seed value. Signed-off-by: Byron Ruth <[email protected]>
…by rejecting uses of Sign/Verify [FIX] error messages as per PR [FIX] unified the nkey and curve key interfaces [FIX] made CreatePairWithRand delegate to CreateCurveKeysWithRand for curve prefixes [FIX] made FromSeed delegate to FromCurveSeed for curve prefixes
aricart
force-pushed
the
normalize-curve
branch
from
1120a48
to
aaea856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the interface for nkeys/curvekeys the same to allow tooling downstream to just deal with seeds/public keys properly.
I think this is a first cut at this issue. Internally it would be better if the old encode/decode/create were augmented to understand the curve key and delegate their initialization to them as necessary.