Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: bump staticcheck GHAction #49

Merged
merged 1 commit into from
Mar 16, 2023
Merged

CI: bump staticcheck GHAction #49

merged 1 commit into from
Mar 16, 2023

Conversation

philpennock
Copy link
Member

For initial setup, I used the docs at https://staticcheck.io/docs/running-staticcheck/ci/github-actions/ which worked, but we noticed slightly late that there were deprecation warnings on our shiny new GitHub Action.
Meanwhile, https://github.com/marketplace/actions/staticcheck has a newer version of the action.

So bump the staticcheck action version (not the staticcheck binary version).

@philpennock
CI: bump staticcheck GHAction
9fe76da 
For initial setup, I used the docs at
<https://staticcheck.io/docs/running-staticcheck/ci/github-actions/> which
worked, but we noticed slightly late that there were deprecation warnings on
our shiny new GitHub Action.
Meanwhile, <https://github.com/marketplace/actions/staticcheck> has a newer
version of the action.

So bump the staticcheck action version (not the staticcheck binary version).
aricart
aricart approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4441310617

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.429%
Totals Coverage Status
Change from base Build 4441246471: 0.0%
Covered Lines: 417
Relevant Lines: 525
💛 - Coveralls

@philpennock philpennock merged commit 9fe76da into main Mar 16, 2023
@philpennock philpennock deleted the pdp/bump-staticcheck branch March 16, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart approved these changes

@wallyqs wallyqs Awaiting requested review from wallyqs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philpennock @coveralls @aricart