Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash with corrupted audio #188

Closed
ssnseawolf opened this issue May 12, 2017 · 1 comment
Closed

Crash with corrupted audio #188

ssnseawolf opened this issue May 12, 2017 · 1 comment

Comments

@ssnseawolf
Copy link

ssnseawolf commented May 12, 2017 •
edited
Loading

When handling certain cases of corrupted audio, WaveFormatConversionProvider's conversionStream is null, possibly due to strange things happening with Windows Multimedia. It seems conversionStream isn't checked for null and throws an exception in Dispose(). This crash occurs in my own testing and in NAudioWpfDemo, 5-10 seconds after attempting to load the file.

I am not well-versed in .NET, but this condition is a problem because I'm unable to trap the exception in try-catch from external code.

File link (too big for GitHub) here.
markheath added a commit that referenced this issue May 13, 2017
@markheath
Fix for #188 - WaveFormatConversionProvider can throw an error in fin…
48aec89 
…aliser if not constructed
@markheath
Copy link
Contributor

thanks for reporting, have checked in a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markheath @ssnseawolf