Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finnp patch 1 - Handle error events correctly #164

Merged
merged 4 commits into from
Jul 26, 2019
Merged

Finnp patch 1 - Handle error events correctly #164

merged 4 commits into from
Jul 26, 2019

Commits on Mar 23, 2017

  1. Handle error events correctly 

    The `onerror` and `ontimeout` handler are not calling back with errors but with error events (without any messages). Therefore the `errorFunc` is wrapping them as `Error: [ProgressEvent object]`. 

Here's my quick proposal on how to fix this. Just pass generic error messages to the `errorFunc`, then there will be no case where the error needs to be constructed there.
    @finnp
    finnp authored Mar 23, 2017
    Configuration menu
    Copy the full SHA
    21315c2 View commit details
    Browse the repository at this point in the history

  2. fix error messages for tests

    @finnp
    finnp committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    c5c9139 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2017

  1. Merge branch 'patch-1' of https://github.com/finnp/xhr into finnp-pat… 

    …ch-1
    @naugtur
    naugtur committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    de15551 View commit details
    Browse the repository at this point in the history

  2. remove new keywords and use .bind

    @naugtur
    naugtur committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    d1a9ff9 View commit details
    Browse the repository at this point in the history