Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosened backend constraints #14

Open
wants to merge 3 commits into
base: persistent-mysql-haskell
Choose a base branch
from

Conversation

RikvanToor
Copy link

@RikvanToor RikvanToor commented Mar 3, 2021

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

This PR changes the creation of SqlBackends to some type backend for which the constraints IsPersistBackend backend, BaseBackend backend ~ SqlBackend, BackendCompatible SqlBackend backend hold. This allows the user to use this package with other backends than just SqlBackend. My own use case for this is to be able to use SqlReadBackend. This way, I can run read-only queries on a different connection than writing queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant