Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add few more Tests for RateLimiter #2000

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add few more Tests for RateLimiter #2000

wants to merge 3 commits into from
+104 −23

Conversation

Pushkarm029
Copy link
Contributor

Pull Request

  • Removed the Option type from the keyed_quotas parameter and updating the corresponding method calls.
  • Added new tests for custom key quotas, multiple keys, quota reset, and different quotas to ensure comprehensive coverage of rate limiting functionality.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested?

make cargo-test

@Pushkarm029
increase-code-coverage
2db9890 
Signed-off-by: Pushkar Mishra <[email protected]>
@Pushkarm029
Copy link
Contributor Author

🎉PR #2000

@Pushkarm029 Pushkarm029 marked this pull request as ready for review October 13, 2024 09:51
@Pushkarm029
fix tests
dcc94ab 
Signed-off-by: Pushkar Mishra <[email protected]>
@Pushkarm029
fix
160d453 
Signed-off-by: Pushkar Mishra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Pushkarm029