Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use datafusion for querying parquet #997

Merged
merged 29 commits into from
Apr 12, 2023
Merged

Conversation

twitu
Copy link
Collaborator

@twitu twitu commented Feb 11, 2023

Pull Request

Use datafusion to register data sources and make queries. Relevant files are

  • src/bin/fusion.rs - example with tests
  • src/datafusion.rs - reader implementation
  • quote_tick.rs - decoding a record batch for quote tick

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested?

Example has tests that passed.

@twitu twitu marked this pull request as draft February 11, 2023 14:07
@cjdsellers
Copy link
Member

Looks like just some Windows path error:

Starting build...
Compiling Rust libraries...
(cd nautilus_core && cargo build --target x86_64-pc-windows-msvc --all-features)
Traceback (most recent call last):
  File "D:\a\nautilus_trader\nautilus_trader\build.py", line 306, in <module>
    build()
  File "D:\a\nautilus_trader\nautilus_trader\build.py", line 264, in build
    _copy_rust_dylibs_to_project()
  File "D:\a\nautilus_trader\nautilus_trader\build.py", line 215, in _copy_rust_dylibs_to_project
    shutil.copyfile(src=src, dst=dst)
  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\shutil.py", line 264, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: 'D:\\a\\nautilus_trader\\nautilus_trader\\nautilus_core\\target\\x86_64-pc-windows-msvc/debug/nautilus_pyo3.dll'
============================= test session starts =============================
platform win32 -- Python 3.9.13, pytest-7.2.2, pluggy-1.0.0
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: D:\a\nautilus_trader\nautilus_trader, configfile: pyproject.toml, testpaths: tests
plugins: asyncio-0.20.3, benchmark-4.0.0, cov-4.0.0, mock-3.10.0, xdist-3.2.0
asyncio: mode=strict
collected 0 items / 1 error
run-last-failure: 1 known failures not in selected tests

=================================== ERRORS ====================================

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (6b1ccf8) 90.88% compared to head (edc5caf) 90.86%.

❗ Current head edc5caf differs from pull request most recent head cb45043. Consider uploading reports for the commit cb45043 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #997      +/-   ##
===========================================
- Coverage    90.88%   90.86%   -0.02%     
===========================================
  Files          257      257              
  Lines        26512    26182     -330     
===========================================
- Hits         24095    23790     -305     
+ Misses        2417     2392      -25     

see 32 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjdsellers cjdsellers merged commit 05636f2 into develop Apr 12, 2023
@cjdsellers cjdsellers deleted the persistence-datafusion branch April 12, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Relating to the Rust core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants