[DAO] Exclude inactive stakers from votings #745
Conversation
aguycalled
requested review from
mxaddict,
dantudor,
proletesseract and
chasingkirkjufell
|
untested ACK |
|
A new build of f8ff873 has completed succesfully! |
|
A new build of 737812d has completed succesfully! |
|
737812d is a blsct commit. the build bot posted to the wrong thread. |
|
The text for showing voting status is not accurate. In this example, I have generate 5 blocks with "excludevote" node so the voting cycle block count should is 5. I voted1yes with 4 blocks remaining. Wallet thinks that it already passes both the quorum and amount of yes votes needed. The bug is not impactful due to the fact as voting continues, the wallet will eventually update to correct quorum and behavior. |
|
should be fixed now. i also added a rpc command |
|
A new build of a6ac923 has completed succesfully! |
|
I couldn't get the node to switch to exclude mode even after 10 cycles of inactivity. Is there a way to check if the mode has entered exclude mode? |
|
were votes happening during those 10 cycles? |
|
Does other nodes need to be voting? ie. if the proposal is not getting any votes, will it be counted into the exclude cycle? |
if no one votes on a cycle, then this cycle does not count in the auto exclude counter |
|
A new build of 8489cee has completed succesfully! |
There was a problem hiding this comment.
Tested local build on Ubuntu 20.04
- Wallet launches with -excludevote=1
- Votes are not counted when wallet is launched with excludevote=1 for proposal consultations, and consensus changes
- Proposal and consultation quorum is reduced when blocks are mined by excludevote nodes
- Wallet enters excludevote mode after 10 cycles of inactivity
|
@aguycalled @chasingkirkjufell how do I know if a node has entered into |
|
i don't believe you can @mxaddict |
|
i verified it by generating blocks and seeing that quorum has dropped with another node voting. |
|
Gotcha
…On Thu, Oct 29, 2020, 07:13 chasingkirkjufell ***@***.***> wrote:
i verified it by generating blocks and seeing that quorum has dropped with
another node voting.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#745 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIDAKM5E44P2NH6I2LB7DTSNCQQ5ANCNFSM4SMBDULA>
.
|
|
the mined blocks would have nonce==1 |
|
A new build of ae49b2e has completed succesfully! |
|
@aguycalled can you explain a bit more about the changes to the tests? I noticed that the status checks have all been updated to just check == "pending" in most of the test scenarios. |
|
I assume this change is only for tests that were expecting a variant of |
|
yes, you are right |
Ok, cool. I just checked the source that was generating the text and now it makes sense. |
This PR proposes a consensus change signaled by version bit 28 to allow excluding stakers from the DAO votings.
Nodes (like users who do not want to participate in the votings or exchanges which activate staking) will be able to exclude their staked blocks from the quorum by indicating the option
-excludevote=1, preventing a scenario where a big enough amount of staking coins not engaging in the governance process could make impossible to reach the acceptance/rejection thresholds.Additionally, a node will label automatically their blocks to be excluded even if
-excludevote=1is no specified, whenever the staker hasn't been active voting in any of the last 10 voting cycles which had an active vote. This is reverted whenever the staker casts a vote.Blocks are labeled to be excluded by activating the right-most bit of their
nOnceparameter.