DAO protocol upgrade #856

aguycalled · 2021-10-13T15:27:30Z

This PR proposes changes in the DAO voting system signalled by version bit 11.

Super Proposals

Super Proposals do not take coins out of the Community Fund but print them new.

Super Proposals can be created through the GUI or using the createproposal RPC command by setting to true the super parameter.

They are signalled in the RPC commands with super_proposal set to true.

Requirement for approval is 75% quorum and 90% acceptance.

What to test

Super Proposals only work when the deployment is active.
Super Proposals are only approved with the specified requirements.
Super Proposals do not depend on the amount available on the Community Fund.
Approval, rejection, expiration, block reorganisation do not affect the amount available in the Community Fund.
Both RPC and GUI functionality work correctly.

Combined voting of consensus parameters

Not implemented in GUI yet, only in RPC commands.

A combined vote for change of consensus parameters can be started using the RPC command proposecombinedconsensuschange.

Example:

proposecombinedconsensuschange '[1, 2]' '[100, 100]'

Additional values can be proposed with proposeanswer:

proposeanswer f54c67f64fa1be51f23d9739d1f6b6a8e10d73f81ea8b7438445b3e52371ba43 '[150, 100]'

What to test

Combined votes only work when the deployment is active.
Combined votes can't be created when at least one of the indicated consensus parameters already has a voting active.
Voting for those consensus change proposals work correctly.
Proposed answers can't be duplicated.
Proposed answers can't be the current value of the consensus parameters.
RPC functionality work correctly.
Please add as a comment to the Pull Request which parts of the GUI would need to be adapted to allow interaction with this new kind of votes.

chasingkirkjufell · 2021-10-15T07:15:51Z

i'd try to add this to the stressor and run it

mxaddict · 2021-10-16T03:00:12Z

@aguycalled seems this PR has a few conflicts with latest master

aguycalled · 2021-10-16T10:11:36Z

@aguycalled seems this PR has a few conflicts with latest master

fixed

aguycalled · 2021-10-18T16:03:04Z

i'd try to add this to the stressor and run it

would you like to add it yourself or should I add it?

chasingkirkjufell · 2021-10-18T16:05:28Z

i'd try to add this to the stressor and run it

would you like to add it yourself or should I add it?

I'd like to add it myself unless you're in a rush since I won't be able to get to it until later this week.

chasingkirkjufell · 2021-10-22T15:35:14Z

local build error

chasingkirkjufell · 2021-10-22T16:47:00Z

mxaddict · 2021-10-25T03:32:15Z

@aguycalled did gitian build the latest commit for this PR?

mxaddict · 2021-10-25T10:13:15Z

@aguycalled is there a command to check the current cfund balance via RPC?

mxaddict · 2021-10-25T10:22:34Z

@aguycalled is this message correct?

mxaddict · 2021-10-25T11:40:27Z

Tested a super proposal with more amount requested than balance from cfund, worked nicely, was able to pass the proposal and create a payment request and receive the requested amount (GENERATED from AIR)

mxaddict · 2021-10-25T11:47:54Z

Tested super proposal via cli, worked as well, generated fresh coins and was able to request a payment, cfundstats was unfaffected throughout the process.

mxaddict · 2021-10-25T11:49:26Z

This PR is looking good, I guess once the GUI bug is fixed (able to created super proposal even when the deployment was not approved) this PR should be good.

@chasingkirkjufell how did you get the node to crash with this branch? I remember you mentioned a crashed node when using this branches build.

mxaddict

Ahh, this was the cause for the message being messed up.

chasingkirkjufell · 2021-10-27T17:06:35Z

@mxaddict i updated my stress script and crashed the nodes. i provided the bt to aguycalled and it seems to be fixed so far. i'm still updating the script to test the combined consensus.

mxaddict · 2021-10-27T17:40:45Z

Nice

…

On Thu, Oct 28, 2021, 01:06 chasingkirkjufell ***@***.***> wrote: @mxaddict <https://github.com/mxaddict> i updated my stress script and crashed the nodes. i provided the bt to aguycalled and it seems to be fixed so far. i'm still updating the script to test the combined consensus. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#856 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDAKNPGGIRIPWFQU37UETUJAWSLANCNFSM5F5PPPLA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

navbuilder · 2021-10-27T20:46:55Z

A new build of 756ef59 has completed succesfully!
Binaries available at https://build.nav.community/binaries/super-dao

navbuilder · 2021-10-30T16:54:07Z

A new build of a91aa23 has completed succesfully!
Binaries available at https://build.nav.community/binaries/super-dao

navbuilder · 2021-11-02T17:21:29Z

A new build of 32308f8 has completed succesfully!
Binaries available at https://build.nav.community/binaries/super-dao

navbuilder · 2021-11-02T22:20:15Z

A new build of e7c0d04 has completed succesfully!
Binaries available at https://build.nav.community/binaries/super-dao

navbuilder · 2021-11-03T03:16:02Z

A new build of 9137113 has completed succesfully!
Binaries available at https://build.nav.community/binaries/super-dao

navbuilder · 2021-11-03T19:31:04Z

A new build of f9bcb64 has completed succesfully!
Binaries available at https://build.nav.community/binaries/super-dao

navbuilder · 2021-11-04T14:35:58Z

A new build of 5c6d837 has completed succesfully!
Binaries available at https://build.nav.community/binaries/super-dao

* fix combined consensus creation * fix

navbuilder · 2021-11-05T12:49:34Z

A new build of 50009f3 has completed succesfully!
Binaries available at https://build.nav.community/binaries/super-dao

Conflicts: src/chainparams.cpp

chasingkirkjufell

updated stressor and stressed this PR with a local build on ubuntu 20.04

mxaddict · 2021-11-09T21:37:18Z

@aguycalled I'm doing final testing on this PR, once done will approve and merge, I think the GUI for the combined voting should be a seperate PR.

navbuilder · 2021-11-14T17:55:48Z

A new build of 87a95c6 has completed succesfully!
Binaries available at https://build.nav.community/binaries/super-dao

alex v added 3 commits October 13, 2021 13:15

super dao

73573ce

changes

068ab7c

fix create preq

1e33adf

aguycalled requested review from 0x2830, chasingkirkjufell, dantudor, matt-auckland, mxaddict, proletesseract and red010b37 October 13, 2021 15:27

aguycalled added the ready for review label Oct 13, 2021

Merge branch 'master' into super-dao

494ece2

alex v added 4 commits October 19, 2021 19:24

fix

f5c142f

fix to json

27e709f

Merge branch 'super-dao' of github.com:aguycalled/navcoin-core into HEAD

27af7d4

Update dao.cpp

3407e97

alex v added 2 commits October 22, 2021 17:36

Update dao.cpp

716e71d

Merge branch 'master' into super-dao

2fdab06

alex v added 2 commits October 22, 2021 19:05

fix merge

9347e0d

fix

5589b78

alex v added 2 commits October 25, 2021 16:31

Fix missing comma

0138053

Create .empty

756ef59

mxaddict reviewed Oct 25, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into super-dao

a91aa23

alex v added 2 commits November 2, 2021 13:22

log

32308f8

add -debug=daoextra to stressor

e7c0d04

xtra log

9137113

sort consultation answers

f9bcb64

canswer hash calc

5c6d837

Update stressor (#68)

50009f3

* fix combined consensus creation * fix

Merge remote-tracking branch 'fork/master' into super-dao

87a95c6

Conflicts: src/chainparams.cpp

chasingkirkjufell approved these changes Nov 8, 2021

View reviewed changes

mxaddict self-requested a review November 10, 2021 02:08

mxaddict approved these changes Nov 10, 2021

View reviewed changes

mxaddict merged commit f5b5582 into navcoin:master Nov 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAO protocol upgrade #856

DAO protocol upgrade #856

aguycalled commented Oct 13, 2021 •

edited

Loading

chasingkirkjufell commented Oct 15, 2021

mxaddict commented Oct 16, 2021

aguycalled commented Oct 16, 2021

aguycalled commented Oct 18, 2021

chasingkirkjufell commented Oct 18, 2021

chasingkirkjufell commented Oct 22, 2021

chasingkirkjufell commented Oct 22, 2021

mxaddict commented Oct 25, 2021

mxaddict commented Oct 25, 2021

mxaddict commented Oct 25, 2021

mxaddict commented Oct 25, 2021

mxaddict commented Oct 25, 2021 •

edited

Loading

mxaddict commented Oct 25, 2021

mxaddict left a comment

chasingkirkjufell commented Oct 27, 2021

mxaddict commented Oct 27, 2021 via email

navbuilder commented Oct 27, 2021

navbuilder commented Oct 30, 2021

navbuilder commented Nov 2, 2021

navbuilder commented Nov 2, 2021

navbuilder commented Nov 3, 2021

navbuilder commented Nov 3, 2021

navbuilder commented Nov 4, 2021

navbuilder commented Nov 5, 2021

chasingkirkjufell left a comment

mxaddict commented Nov 9, 2021

navbuilder commented Nov 14, 2021

DAO protocol upgrade #856

DAO protocol upgrade #856

Conversation

aguycalled commented Oct 13, 2021 • edited Loading

Super Proposals

What to test

Combined voting of consensus parameters

What to test

chasingkirkjufell commented Oct 15, 2021

mxaddict commented Oct 16, 2021

aguycalled commented Oct 16, 2021

aguycalled commented Oct 18, 2021

chasingkirkjufell commented Oct 18, 2021

chasingkirkjufell commented Oct 22, 2021

chasingkirkjufell commented Oct 22, 2021

mxaddict commented Oct 25, 2021

mxaddict commented Oct 25, 2021

mxaddict commented Oct 25, 2021

mxaddict commented Oct 25, 2021

mxaddict commented Oct 25, 2021 • edited Loading

mxaddict commented Oct 25, 2021

mxaddict left a comment

Choose a reason for hiding this comment

chasingkirkjufell commented Oct 27, 2021

mxaddict commented Oct 27, 2021 via email

navbuilder commented Oct 27, 2021

navbuilder commented Oct 30, 2021

navbuilder commented Nov 2, 2021

navbuilder commented Nov 2, 2021

navbuilder commented Nov 3, 2021

navbuilder commented Nov 3, 2021

navbuilder commented Nov 4, 2021

navbuilder commented Nov 5, 2021

chasingkirkjufell left a comment

Choose a reason for hiding this comment

mxaddict commented Nov 9, 2021

navbuilder commented Nov 14, 2021

aguycalled commented Oct 13, 2021 •

edited

Loading

mxaddict commented Oct 25, 2021 •

edited

Loading