Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with restoring cropPosition when bitmap is scrolled to edge #17

Closed
onlyway opened this issue Sep 18, 2016 · 8 comments
Closed
Labels

Comments

@onlyway
Copy link

onlyway commented Sep 18, 2016

When I want to restore bitmap somewhere centered everything is working fine, but when I'm trying to scroll max to top or bottom, after restoration I'm not exactrly at the same position. I have margin from top or from bottom. Is there any workaround for this?

@onlyway
Copy link
Author

onlyway commented Sep 18, 2016

In sample app I see the same bug with edges

@helloyako
Copy link
Contributor

@onlyway
Yes, that is bug.. I'm so sorry. 😭

@helloyako helloyako added the bug label Nov 30, 2016
@onlyway
Copy link
Author

onlyway commented Nov 30, 2016

Do you have any walk around for this?

@helloyako
Copy link
Contributor

Not yet

@onlyway
Copy link
Author

onlyway commented Dec 1, 2016

Ok thx, i've tried to solve this couple of Tomek but no success :)

helloyako added a commit that referenced this issue Jan 4, 2017
@helloyako
Copy link
Contributor

@onlyway
How are you? :)
I fixed this issue.

I will include this spec in v1.2.0. but it's not released.
You can use 1.2.0-snapshot or develop branch source code.

snapshot version from maven

repositories {
    maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
}
dependencies {
   compile 'com.naver.android.helloyako:imagecropview:1.2.0-SNAPSHOT'
}

check please

@helloyako
Copy link
Contributor

resolved v1.2.0

@onlyway
Copy link
Author

onlyway commented Feb 6, 2017

Thx ;) I'll check it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants