Skip to content

Commit

Permalink
chore(benchmark): ufix to work with different d3.js version
Browse files Browse the repository at this point in the history
  • Loading branch information
netil committed Apr 8, 2021
1 parent 24d86f0 commit 18d52de
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions demo/benchmark/benchmark.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ window.bench = {
chart: null,
timer: null,
billboard: null,
target: ["1.12.11", "2.0.0", "latest"],
target: ["1.12.11", "2.0.0", "3.0.0", "latest"],
$el: {
version: document.getElementById("version"),
type: document.getElementById("type"),
Expand Down Expand Up @@ -44,7 +44,7 @@ window.bench = {

this.billboard && document.head.removeChild(this.billboard);
this.billboard = document.createElement("script");
this.billboard.src = `https://cdn.jsdelivr.net/npm/billboard.js${version === "latest" ? "" : `@${version}`}/dist/billboard.js`;
this.billboard.src = `https://cdn.jsdelivr.net/npm/billboard.js${version === "latest" ? "" : `@${version}`}/dist/billboard.pkgd.min.js`;

this.billboard.onload = () => {
const {options} = this.$el.version;
Expand Down
1 change: 0 additions & 1 deletion demo/benchmark/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<title>Benchmark</title>
<link rel="stylesheet" href="./benchmark.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/billboard.js/dist/billboard.min.css">
<script src="https://d3js.org/d3.v5.min.js"></script>
</head>
<body>
<h1>Benchmark</h1>
Expand Down

0 comments on commit 18d52de

Please sign in to comment.