fix(point): Fix custom point for nullish data

Exclude position computation for nullish data Fix #2107
naver · May 28, 2021 · 8c198f2 · 8c198f2
1 parent 8e2d2da
commit 8c198f2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/ChartInternal/shape/point.ts b/src/ChartInternal/shape/point.ts
@@ -500,8 +500,8 @@ export default {
 			withTransition, flow, selectedCircles) {
 			const {width, height} = element.node().getBBox();
 
-			const xPosFn2 = d => xPosFn(d) - width / 2;
-			const yPosFn2 = d => yPosFn(d) - height / 2;
+			const xPosFn2 = d => (isValue(d.value) ? xPosFn(d) - width / 2 : 0);
+			const yPosFn2 = d => (isValue(d.value) ? yPosFn(d) - height / 2 : 0);
 			let mainCircles = element;
 
 			if (withTransition) {

diff --git a/test/shape/point-spec.ts b/test/shape/point-spec.ts
@@ -130,6 +130,18 @@ describe("SHAPE POINT", () => {
 				expect(scale).to.be.equal(1.75);
 			});
 		});
+
+		it("set option: nullish data", () => {
+			args.data.columns = [
+				["data1", 6, 4, null]
+			];
+
+			args.point.pattern = ['<circle cx="4" cy="4" r="4" />'];
+		});
+
+		it("custom point's position for null data shoudn't be set as NaN", () => {
+			expect(chart.$.circles.filter(":last-child").attr("y")).to.not.equal("NaN");
+		});
 	});
 
 	describe("point transition", () => {