Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts are broken on mobile when no x focus grid is shown #1306

Closed
stof opened this issue Apr 6, 2020 · 3 comments
Closed

Charts are broken on mobile when no x focus grid is shown #1306

stof opened this issue Apr 6, 2020 · 3 comments
Labels
bug released

Comments

@stof
Copy link
Contributor

stof commented Apr 6, 2020

Description

The code at

billboard.js/src/internals/grid.js

Line 389 in 01ba388

const d = $$.grid.select(`line.${CLASS.xgridFocus}`).datum();
calls .datum() on a d3 selection, while this selection can be empty. Calling this method on an empty selection triggers a TypeError by accessing a property on null.

Steps to check or reproduce

This happens when grid.focus.show is set to false in options of a line chart. It only affects touch devices.
@stof
Copy link
Contributor Author

stof commented Apr 6, 2020

I'm using version 1.12.1

@netil netil added the bug label Apr 7, 2020
@netil
Copy link
Member

netil commented Apr 7, 2020

@stof thanks for the report.

@netil netil mentioned this issue Apr 7, 2020
Merged
@netil netil closed this as completed in be61198 Apr 7, 2020
netil pushed a commit that referenced this issue Apr 9, 2020
@semantic-release-bot
chore(release): 1.12.3 [skip ci]
e5421dd 
## [1.12.3](1.12.2...1.12.3) (2020-04-09)

### Bug Fixes

* **grid:** Fix possible error when grid.focus.show set false ([be61198](be61198)), closes [#1306](#1306)
@netil
Copy link
Member

netil commented Apr 9, 2020

🎉 This issue has been resolved in version 1.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@netil netil added the released label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stof @netil