fix: fix incorrect isTrusted value in finishScroll event #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This sets the
isTrustedvalue infinishScrollevent more accurately after fixing the bug in #34.First, I removed the following logic from the
changeevent.if (nativeEvent && !isHold) { return; }Removing this part will not change the behavior, as it was working correctly in the previous situation where
isHoldwas being calculated astrue.And I fixed an issue where
_isAnimationwas being set incorrectly, affecting theisTrustedvalue of finishScroll event._isAnimationshould be set totruewhen conveyer is not in a holding state and achangeevent is not fired by the user wheel, assuming thatchangeevent has occurred due to internal methods.