fix: unobserve removed panel when panel change

naver · Aug 23, 2024 · 3763e79 · 3763e79
1 parent a4761b8
commit 3763e79
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/core/AutoResizer.ts b/src/core/AutoResizer.ts
@@ -79,6 +79,13 @@ class AutoResizer {
     return this;
   }
 
+  public unobserve(element: Element): this {
+    if (this._resizeObserver) {
+      this._resizeObserver.unobserve(element);
+    }
+    return this;
+  }
+
   private _onResize = () => {
     const flicking = this._flicking;
     const resizeDebounce = flicking.resizeDebounce;

diff --git a/src/renderer/Renderer.ts b/src/renderer/Renderer.ts
@@ -339,6 +339,9 @@ abstract class Renderer {
       panelsAdded.forEach((panel) => {
         flicking.autoResizer.observe(panel.element);
       });
+      panelsRemoved.forEach((panel) => {
+        flicking.autoResizer.unobserve(panel.element);
+      });
     }
 
     void this.render();