-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certificate Generation #785
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments
if(!openModal){ | ||
axios({ | ||
method: METHODS.GET, | ||
url: `${process.env.REACT_APP_MERAKI_URL}/certificate`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirithiv2000 Making the API call directly as follows (removing the token):
fetch('https://api.merakilearn.org/certificate', {headers: {"Authorization": 'xxx', "accept": "application/json"}}).then(res => console.log(res));
is resulting in an Internal Server Error for me. Took a quick look and this line here: https://github.com/navgurukul/sansaar/blob/dev-copy/lib/services/generateCertificate.js#L86
will cause an error (can't call toString
on null
) and isn't used so it can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized that was probably deliberate to force an error to catch since it was in a try
block. But it crashes for me when a direct request is made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you marked the course as complete through API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you marked the course as complete through API?
No, so the request should produce an error response here, I just wasn't sure if it should be a generic 500 Internal Server Error.
…o Certificate-Generation
The You can read this thread: wojtekmaj/react-pdf#1043 Below is the screenshot attached |
Refer to issue #755
People to loop in / review from
@komalahire @jschanker