Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ComboBox trigger onClear event når option velges #2163

Closed
otenav opened this issue Aug 15, 2023 · 1 comment · Fixed by #2170
Closed

[BUG] ComboBox trigger onClear event når option velges #2163

otenav opened this issue Aug 15, 2023 · 1 comment · Fixed by #2170
Assignees
Labels
bug 🐛 Feil i systemet

Comments

@otenav
Copy link
Contributor

otenav commented Aug 15, 2023

Hva er feilen/problemet?

Tusen takk for en helt fantasisk jobb med ComboBox! Kan bare forestille meg hvor jobb som ligger bak den 🎉 🤩

Forsøker å lage en controlled combo box, ved bruk av filtered options, og alt fungerer fint. Men når jeg velger en option, så trigges onClear eventen to ganger - og da blir det jeg valgte slettet.

Med min koden under, så kan issuet gjennskapes:

  • Skriv "Norge"
  • Velg Norge fra options
  • Se at combobox input value forblir tom
  • Sjekk i console at det står 2 stk "clear" logglinjer

Eksempel/Tilleggsinformasjon (valgfri)

import { UNSAFE_Combobox } from "@navikt/ds-react";
import { useState } from "react";

const ComboBoxExample = () => {
  const countries = [
    "Norge",
    "Sverige",
    "Danmark",
    "Finland",
    "Island",
    "Storbritannia",
    "Tyskland",
    "Frankrike",
    "Spania",
    "Portugal",
    "Italia",
    "Hellas",
    "Kroatia",
    "Tyrkia",
  ];

  const [filteredOptions, setFilteredOptions] = useState([]);
  const [value, setValue] = useState("");

  const onChange = (e) => {
    const text = e.target.value;

    setValue(text);
    if (text.length > 0) {
      const found = countries.filter(
        (c) => c.toLowerCase().indexOf(text.toLowerCase()) !== -1
      );
      setFilteredOptions(found);
    } else {
      setFilteredOptions([]);
    }
  };

  const onToggleSelected = (option, isSelected) => {
    setValue(option);
    setFilteredOptions([]);
  };

  const onClear = () => {
    console.log("clear");
    setValue("");
    setFilteredOptions([]);
  };

  return (
    <div>
      <UNSAFE_Combobox
        label="Hva er den aller kuleste Star Wars-filmen noensinne, helt objektivt?"
        className="mb-4"
        onChange={onChange}
        onToggleSelected={onToggleSelected}
        onClear={onClear}
        filteredOptions={filteredOptions}
        options={[]}
        value={value}
        isListOpen={filteredOptions.length > 0}
        toggleListButton={false}
      />
    </div>
  );
};

export default ComboBoxExample;
@KenAJoh
Copy link
Collaborator

KenAJoh commented Aug 18, 2023

Hei, dette er fikset i nyeste versjon nå 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Feil i systemet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants