Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/combobox.on clear is fired more times than expected #2170

Merged

Conversation

it-vegard
Copy link
Contributor

Fixes #2163

Description

Eliminates double calls to onClear when toggling a value in Combobox

Change summary

  • Removed redundant calls to Combobox.onClear
  • Added tests to check for the number of calls onChange, onClear and onToggleSelected is called

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023

🦋 Changeset detected

Latest commit: e8b9d03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Storybook demo

Endringer til review: 1

d5219fb1d | 48 komponenter | 308 stories

@KenAJoh KenAJoh merged commit cf01a6e into main Aug 16, 2023
2 checks passed
@KenAJoh KenAJoh deleted the bugfix/combobox.onClear-is-fired-more-times-than-expected branch August 16, 2023 08:45
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ComboBox trigger onClear event når option velges
2 participants