Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add close button to alert #2079

Merged
merged 14 commits into from
Jun 29, 2023
Merged

add close button to alert #2079

merged 14 commits into from
Jun 29, 2023

Conversation

JulianNymark
Copy link
Contributor

@JulianNymark JulianNymark commented Jun 26, 2023

Description

Change summary

  • add close button to alert
  • added a storybook interaction/play for alert with close buttons
  • close button state is managed outside the component, and you pass in a callback 'onClose' + set 'closeButton' props

PR Checklist 📝 (Remove fields after check!)

Documentation 📝

  • Add/update component-demos for component aksel.nav.no/website/pages/eksempler
  • Create/Update documentation in sanity if needed
    Note: Props, tokens and examples only updates to sanity on merge to main

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

🦋 Changeset detected

Latest commit: aa9b591

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Minor
@navikt/ds-react Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

Endringer til review: 10

683b3bf28 | 45 komponenter | 271 stories

@navikt/core/css/alert.css Outdated Show resolved Hide resolved
@navikt/core/css/alert.css Outdated Show resolved Hide resolved
KenAJoh
KenAJoh previously approved these changes Jun 29, 2023
@KenAJoh KenAJoh merged commit b059588 into main Jun 29, 2023
3 checks passed
@KenAJoh KenAJoh deleted the alert branch June 29, 2023 11:43
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants