Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removable chips type now defaults to button #2124

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Removable chips type now defaults to button #2124

merged 6 commits into from
Aug 3, 2023

Commits on Aug 1, 2023

  1. Removable chips type now defaults to button

    @andnorda
    andnorda committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    462bdc1 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. 📝 Changeset

    @KenAJoh
    KenAJoh committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5c06135 View commit details
    Browse the repository at this point in the history

  2. 📝 Changeset update

    @KenAJoh
    KenAJoh committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    3282f38 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into removable-chips-type-button

    @KenAJoh
    KenAJoh authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    59f1a6d View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Remove OverridableComponent from Chips.Removable. This component shou… 

    …ld always be a button, and it is not currently used in any other way.

The reason for making this change now, is that we put type="button" on the Chip.Removable to prevent a submit event when the chip is clicked inside a form.
    @it-vegard
    it-vegard committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a3ba0fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into removable-chips-type-button

    @it-vegard
    it-vegard committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    984d4f6 View commit details
    Browse the repository at this point in the history