Missing Combobox.onClear when clearing the input field programatically #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… similar to if the user removed the text manually (e.g. backspace)
🦋 Changeset detectedLatest commit: 9d4d69e The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
KenAJoh
approved these changes
Aug 17, 2023
KenAJoh
deleted the
bugfix/combobox.onchange-is-not-fired-when-clearing-value
branch
Merged
Storybook demod16fb264a | 48 komponenter | 311 stories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We fire onChange anytime the user edits the text or deletes text using backspace. However, if clearing the field through the clear button or when selecting an option in the dropdown, only the onClear callback is triggered. To allow users to use onChange consistently to track the value, we need to trigger onChange in these cases as well.
Change summary