Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial box (heavily inspired by shopify Box) #2195

Merged
merged 116 commits into from
Sep 13, 2023
Merged

initial box (heavily inspired by shopify Box) #2195

merged 116 commits into from
Sep 13, 2023

Conversation

JulianNymark
Copy link
Contributor

@JulianNymark JulianNymark commented Aug 21, 2023 •
edited
Loading

Description

https://github.com/navikt/team-aksel/issues/251

Change summary

  • initial Box (inspired from Shopify, needs to use our own tokens, look & feel like Stack & Grid. Discussion?)

PR Checklist 📝 (Remove fields after check!)

New component? ✨

  • Is the component sufficiently complex to warrant tests? Add some unit-tests for jest.

Documentation 📝

  • Add/update component-demos for component aksel.nav.no/website/pages/eksempler
  • Create/Update documentation in sanity if needed
    Note: Props, tokens and examples only updates to sanity on merge to main

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d7d1ac1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-tokens Minor
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/ds-tailwind Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023 •
edited
Loading

Storybook demo

Endringer til review: 30

b1a71e652 | 57 komponenter | 371 stories

KenAJoh and others added 19 commits August 22, 2023 15:09
@KenAJoh
🎨 Theming-demo
73b8493
@larseirikhansen
rm printHidden prop
ae2cf8d
@larseirikhansen
sr-only: clip is deprecated, adding clip-path
3307f0c
@larseirikhansen
setting up padding story box primitive
47e5779
@JulianNymark
95% complete padding example for Box (dynamic css code unfolding with…
0e78157 
… types)
@larseirikhansen
Merge remote-tracking branch 'origin/main' into primitives-box
6095451
@JulianNymark
WIP on padding/margin for box
2c5c4c8
@JulianNymark
working box padding/block/inline/margin?
3a42c58
@JulianNymark
remove console.log
d4666f6
@JulianNymark
story for Box, copy implementation from padding to apply to margin as…
422b587 
… well
@JulianNymark
remove unwanted props on Box
6318832
@JulianNymark
refactor semantic-colors.json, use json import for types in Box.tsx
bf1c8d4
@JulianNymark
squashme
311b6cd
@JulianNymark
Box: working border & background
df60dc2
@JulianNymark
Merge branch 'main' into primitives-box
bafa6c3
@JulianNymark
🔥 remove props on Box we will not implement in v1
6731bd4
@JulianNymark
refactoring / less things needed (no margin) and things that are brok…
31fe8c6 
…en show up in stories
@JulianNymark
🐛 fix erroneous padding assignment (a flipped index)
2a73c1c
@JulianNymark
fully recreated LinkPanel
30c1b38
@JulianNymark JulianNymark marked this pull request as ready for review August 30, 2023 08:33
KenAJoh and others added 23 commits September 11, 2023 12:04
@KenAJoh
♻️ Forenklet borderRadius
a207bfe
@KenAJoh
🎨 refactor padding in box
aa18a9e
@KenAJoh
🔥 Fjernet unødvendig kode
ad301d8
@KenAJoh
🎨 Oppdatert token for borderWidth
6c3fb78
@KenAJoh
🐛 Default 0px border
aec7028
@KenAJoh
🏷️ Refactor types
08c7219
@KenAJoh
🐛 Fikset stories
db73ffd
@JulianNymark
♻️ refactor away one of the getResponsiveProps(), renaming
cfe67f6
@JulianNymark
♻️ refactor + add token exceptions
078b670
@JulianNymark
Merge branch 'main' into primitives-box
4f2c793
@JulianNymark
🐛 new props based on BoxProps
4ec01bd
@KenAJoh
📝 Oppdatert box-eksempler
69d22f6
@KenAJoh
📝 border-eksempler
8f73cd2
@KenAJoh
📝 shadow-eksempel
130abdd
@KenAJoh
📝 header demo
2d4a086
@KenAJoh
🔥 Fjernet theming demo, la til panel-demo
af4136d
@KenAJoh
🚚 Flyttet show/hide inn i primitives
a804fcd
@JulianNymark
🚚 extract stateful colors to separate files
9c92576
@JulianNymark
🚚 move shadow stateful tokens as well
0bae3cb
@JulianNymark
♻️ rename some Box types
ae80e28
@JulianNymark
🚚 re-add missing token
95a86d6
@JulianNymark
🚚 move types file to utils, (bonus: fix some jsdoc)
d86a817
@JulianNymark
➕ add @navikt/ds-tokens to react
997508a
@JulianNymark JulianNymark merged commit 83c9194 into main Sep 13, 2023
3 checks passed
@JulianNymark JulianNymark deleted the primitives-box branch September 13, 2023 09:25
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalvorHaugan HalvorHaugan HalvorHaugan left review comments

@KenAJoh KenAJoh KenAJoh approved these changes

@larseirikhansen larseirikhansen larseirikhansen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JulianNymark @KenAJoh @larseirikhansen @HalvorHaugan