Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker - eksponere alle props + layout for klikkbar ukenummer #2302

Closed
wants to merge 4 commits into from

Conversation

frodehansen2
Copy link
Contributor

Description

Utvide Datepicker med mulighet for å ha klikkbare ukenumre.

Change summary

  • Eksponere alle props i react-day-picker som ikke er i konflikt med Datepicker.
  • Legge til styling for når bruker har satt props onWeekNumberClick

Comment

Jeg antar det er gjort en vurdering tidligere på å ikke eksponere alle props som react-day-picker har. Men lager en PR uansett. Alternativet til å eksponere alle kan være å eksponere onWeekNumberClickog labelsprops. Da vil hovedfunksjonaliteten med å ha klikkbare ukenummer med mulighet for å sette riktig aria-label på ukenummeret være tilgjengelig.

image

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

🦋 Changeset detected

Latest commit: 8229588

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frodehansen2 frodehansen2 changed the title Datepicker click week number DatePicker - eksponere alle props + layout for klikkbar ukenummer Sep 19, 2023
@github-actions
Copy link
Contributor

Storybook demo

Endringer til review: 1

6dda975e1 | 58 komponenter | 375 stories

@frodehansen2 frodehansen2 deleted the datepicker-click-week-number branch September 28, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant