Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add AsChild to show/hide #2312

Merged
merged 10 commits into from
Sep 26, 2023
Merged

✨ add AsChild to show/hide #2312

merged 10 commits into from
Sep 26, 2023

Conversation

JulianNymark
Copy link
Contributor

Description

AsChild (Slot)

Change summary

asChild

PR Checklist 📝 (Remove fields after check!)

Documentation 📝

  • Add/update component-demos for component aksel.nav.no/website/pages/eksempler
  • Create/Update documentation in sanity if needed
    Note: Props, tokens and examples only updates to sanity on merge to main

Versioning 🏷️

  • Run yarn changeset to generate a version-entry for change.
    • Bug/hotfix: Patch
    • New feature: Minor
    • Breaking change: Major
  • Adding breaking changes? Consider adding a codemod for easier migration.
  • Breaking changes also needs documentation under "Migration"-page on website

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: d42534f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Storybook demo

Endringer til review: 2

e9c64e5fb | 58 komponenter | 376 stories

KenAJoh
KenAJoh previously approved these changes Sep 26, 2023
@JulianNymark JulianNymark merged commit ce837ed into main Sep 26, 2023
3 checks passed
@JulianNymark JulianNymark deleted the asChild branch September 26, 2023 12:13
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants