Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Popover: Ikke lukk ved klikk inni når parent er fokuserbar #2521

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Nov 28, 2023

Mulig fiks for dette: https://nav-it.slack.com/archives/C7NE7A8UF/p1701162226119769
Men aner ikke om det kan brekke noe annet...

Tror feilen ble introdusert i #2303, men kan vel ikke akkurat reverte det heller.

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 73f0d89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Storybook demo

b02c7a6cf | 61 komponenter | 400 stories

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I teorien skal useDismiss (https://floating-ui.com/docs/useDismiss) være god nok for å håndtere dette, men har hatt problemer med den tidligere som førte til custom-løsning

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testet med shadow-dom i /examples/shadow-dom og virket greit der også 🚀

@HalvorHaugan HalvorHaugan merged commit 5cd1a6d into main Nov 28, 2023
2 checks passed
@HalvorHaugan HalvorHaugan deleted the popover-tabindex-fix branch November 28, 2023 15:18
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants