Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocationPin-ikon #2672

Merged
merged 3 commits into from
Jan 30, 2024
Merged

LocationPin-ikon #2672

merged 3 commits into from
Jan 30, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jan 26, 2024

Description

Nytt ikon LocationPin 🎉

@KenAJoh KenAJoh added the ignore-chromatic Hindrer kode i å bli testet med chromatic label Jan 26, 2024
Copy link

changeset-bot bot commented Jan 26, 2024

🦋 Changeset detected

Latest commit: 686fe80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/aksel-icons Patch
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KenAJoh KenAJoh requested a review from a team January 29, 2024 08:28
"@navikt/aksel-icons": patch
---

Ikoner: LocationPin-ikoner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Småpirk) Selv om det teknisk sett er to forskjellige ikoner, så regnes det vel bare som ett ikon med to varianter, eller? Tenker på at "-ikoner" står i flertall. Tidligere har vi skrevet det på denne måten: "Ikoner: Nytt ikon LocationPin"

- lokasjon
variant: Fill
updated_at: 26.01.2024
created_at: 07.03.2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er det slik at ikonet har eksistert før, men ble fjernet ved et uhell? (derav gammel created_at)

(Brukes egentlig disse datoene til noe?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brukes ikke til noe nå nei. Ja antar det har eksistert i figma tidligere;

@KenAJoh KenAJoh merged commit eff9b5e into main Jan 30, 2024
2 checks passed
@KenAJoh KenAJoh deleted the hotfix-icons-pin branch January 30, 2024 13:39
@github-actions github-actions bot mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-chromatic Hindrer kode i å bli testet med chromatic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants