Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Spacer er nå span (tidligere div) #2874

Merged
merged 3 commits into from
Apr 22, 2024
Merged

🎨 Spacer er nå span (tidligere div) #2874

merged 3 commits into from
Apr 22, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Apr 22, 2024

Description

Siden Spacer var default div før kunne dette føre til valideringsfeil for DOM da div ikke kan brukes i phrasing-content. Kan hende jeg har misset noe åpenbart, men tror ikke det skal være noe i veien med å bare sette den til default span.

(Har det noe å si at span får display: inline? navds-stack__spacer bør kanskje settes til display: block;)

Slipper da å legge til OverridableComponent.

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 10ce11e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Storybook demo

727a3421c | 62 komponenter | 203 stories

@KenAJoh KenAJoh enabled auto-merge (squash) April 22, 2024 13:32
@KenAJoh KenAJoh merged commit c3064a0 into main Apr 22, 2024
2 checks passed
@KenAJoh KenAJoh deleted the as-prop-primitives branch April 22, 2024 13:32
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants