Combobox: Remove 'Ingen søketreff' when custom options allowed #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aad64ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 2c60edfbf5 | 63 komponenter | 205 stories |
it-vegard
reviewed
May 6, 2024
@navikt/core/react/src/form/combobox/FilteredOptions/FilteredOptions.tsx
Show resolved
Hide resolved
|
Ser ut som gap fortsatt er der siden det er 2 elementer (og det ene er tomt) 
|
…ikt/aksel into combobox-rm-nohits-if-custom
KenAJoh
approved these changes
May 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://nav-it.slack.com/archives/C04C1G7UWG7/p1714483735032339
På fredagsmøtet snakket vi om dette igjen, så lager en PR så vi kan se mer på det til neste uke og se på hva vi synes gir mest mening.