Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font naming and location preload fix #3114

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Font naming and location preload fix #3114

merged 3 commits into from
Aug 26, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Aug 22, 2024

Description

Reverted change introduced in v6.14 where font locations and references in @font-face changed. This caused a regression where every preload-instance to old font locations no longer linked to the correct file.

Effect of regression is the potential for some FOUT, reducing user experience.

This only affects systems updated to v6.14 or newer, so a small subset of these files.

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 5ace5eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-react Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Storybook demo

Endringer til review: 16

31274ee57 | 88 komponenter | 139 stories

Copy link
Contributor

@JulianNymark JulianNymark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@KenAJoh KenAJoh merged commit 122477c into main Aug 26, 2024
4 checks passed
@KenAJoh KenAJoh deleted the font-naming-preload-fix branch August 26, 2024 07:16
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants