Limit collecting rewards up to 48 intervals #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarinkovic
reviewed
Mar 27, 2024
| @@ -115,7 +115,8 @@ library LibTokenizedVaultStaking { | |||
| bytes32 nextVTokenId = _vTokenId(tokenId, currentInterval + 1); | |||
|
|
|||
| // First collect rewards. This will update the current state. | |||
| _collectRewards(_stakerId, _entityId, currentInterval); | |||
| // If the user does not have anything staked, then skip `_collectRewards()`. | |||
| if (s.stakeBalance[vTokenIdMax][_stakerId] != 0) _collectRewards(_stakerId, _entityId, currentInterval); | |||
…intervals at once
Merged
amarinkovic
added a commit
that referenced
this pull request
May 16, 2024
This reverts commit e2fe5ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to give the user a better error than out of gas when attempting to collect staking rewards through a large number of reward intervals.
We now limit the max number of intervals that a user can collect to 48 and throw a custom error if the user is attempting to collect more.
We added a method called
collectRewardsThroughIntervalwhich lets a user collect up to a specific interval.