ERC20 wrapper #38
Merged
ERC20 wrapper #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/facets/ITokenizedVaultFacet.md
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+100
to
+142
| function permit( | ||
| address owner, | ||
| address spender, | ||
| uint256 value, | ||
| uint256 deadline, | ||
| uint8 v, | ||
| bytes32 r, | ||
| bytes32 s | ||
| ) external { | ||
| require(deadline >= block.timestamp, "PERMIT_DEADLINE_EXPIRED"); | ||
|
|
||
| // Unchecked because the only math done is incrementing | ||
| // the owner's nonce which cannot realistically overflow. | ||
| unchecked { | ||
| address recoveredAddress = ecrecover( | ||
| keccak256( | ||
| abi.encodePacked( | ||
| "\x19\x01", | ||
| DOMAIN_SEPARATOR(), | ||
| keccak256( | ||
| abi.encode( | ||
| keccak256("Permit(address owner,address spender,uint256 value,uint256 nonce,uint256 deadline)"), | ||
| owner, | ||
| spender, | ||
| value, | ||
| nonces[owner]++, | ||
| deadline | ||
| ) | ||
| ) | ||
| ) | ||
| ), | ||
| v, | ||
| r, | ||
| s | ||
| ); | ||
|
|
||
| require(recoveredAddress != address(0) && recoveredAddress == owner, "INVALID_SIGNER"); | ||
|
|
||
| allowances[recoveredAddress][spender] = value; | ||
| } | ||
|
|
||
| emit Approval(owner, spender, value); | ||
| } |
Check notice
Code scanning / Slither
Block timestamp
Comment on lines
+100
to
+142
| function permit( | ||
| address owner, | ||
| address spender, | ||
| uint256 value, | ||
| uint256 deadline, | ||
| uint8 v, | ||
| bytes32 r, | ||
| bytes32 s | ||
| ) external { | ||
| require(deadline >= block.timestamp, "PERMIT_DEADLINE_EXPIRED"); | ||
|
|
||
| // Unchecked because the only math done is incrementing | ||
| // the owner's nonce which cannot realistically overflow. | ||
| unchecked { | ||
| address recoveredAddress = ecrecover( | ||
| keccak256( | ||
| abi.encodePacked( | ||
| "\x19\x01", | ||
| DOMAIN_SEPARATOR(), | ||
| keccak256( | ||
| abi.encode( | ||
| keccak256("Permit(address owner,address spender,uint256 value,uint256 nonce,uint256 deadline)"), | ||
| owner, | ||
| spender, | ||
| value, | ||
| nonces[owner]++, | ||
| deadline | ||
| ) | ||
| ) | ||
| ) | ||
| ), | ||
| v, | ||
| r, | ||
| s | ||
| ); | ||
|
|
||
| require(recoveredAddress != address(0) && recoveredAddress == owner, "INVALID_SIGNER"); | ||
|
|
||
| allowances[recoveredAddress][spender] = value; | ||
| } | ||
|
|
||
| emit Approval(owner, spender, value); | ||
| } |
Check notice
Code scanning / Slither
Block timestamp
Comment on lines
+100
to
+142
| function permit( | ||
| address owner, | ||
| address spender, | ||
| uint256 value, | ||
| uint256 deadline, | ||
| uint8 v, | ||
| bytes32 r, | ||
| bytes32 s | ||
| ) external { | ||
| require(deadline >= block.timestamp, "PERMIT_DEADLINE_EXPIRED"); | ||
|
|
||
| // Unchecked because the only math done is incrementing | ||
| // the owner's nonce which cannot realistically overflow. | ||
| unchecked { | ||
| address recoveredAddress = ecrecover( | ||
| keccak256( | ||
| abi.encodePacked( | ||
| "\x19\x01", | ||
| DOMAIN_SEPARATOR(), | ||
| keccak256( | ||
| abi.encode( | ||
| keccak256("Permit(address owner,address spender,uint256 value,uint256 nonce,uint256 deadline)"), | ||
| owner, | ||
| spender, | ||
| value, | ||
| nonces[owner]++, | ||
| deadline | ||
| ) | ||
| ) | ||
| ) | ||
| ), | ||
| v, | ||
| r, | ||
| s | ||
| ); | ||
|
|
||
| require(recoveredAddress != address(0) && recoveredAddress == owner, "INVALID_SIGNER"); | ||
|
|
||
| allowances[recoveredAddress][spender] = value; | ||
| } | ||
|
|
||
| emit Approval(owner, spender, value); | ||
| } |
Check notice
Code scanning / Slither
Block timestamp
… transferFrom" This reverts commit cc02308.
…sferFrom, without adding libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the ability to expose Nayms' marketplace participation tokens as standard ERC20 tokens.